Skip to content

fix(deps): bump github.com/yuin/goldmark to v1.7.17 - #220

Merged
Mzack9999 merged 1 commit into
devfrom
dwisiswant0/fix/deps/bump-github-com-ulikunitz-xz-to-v0-5-15
Nov 9, 2026
Merged

Mzack9999 merged 1 commit into
devfrom
dwisiswant0/fix/deps/bump-github-com-ulikunitz-xz-to-v0-5-15

Conversation

@dwisiswant0

@dwisiswant0 dwisiswant0 commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

govulncheck reports GO-2026-5320, cross-site scripting in the goldmark
HTML renderer, as reachable from runner.GetUpdateCallback through the
update check in github.com/projectdiscovery/utils, which renders
release notes with github.com/charmbracelet/glamour. dev pulls in
github.com/yuin/goldmark v1.7.4 that way.

Bump goldmark to v1.7.17, which fixes it. The go directive stays at
1.26.10, and no other requirement changes.

The findings in #219 don't apply to dev. Its dependency graph no
longer includes github.com/ulikunitz/xz, github.com/mholt/archiver, or
github.com/nwaples/rardecode, so govulncheck reports none of
GO-2025-3922, GO-2020-0016, GO-2025-4020, GO-2025-3605, or
GO-2024-2698 there. It still lists advisories in golang.org/x/net
v0.58.0 and golang.org/x/crypto v0.55.0 whose vulnerable code isn't
called.

Fixes: #219

@dwisiswant0
dwisiswant0 force-pushed the dwisiswant0/fix/deps/bump-github-com-ulikunitz-xz-to-v0-5-15 branch from b67cb30 to 1b6ba4d Compare November 9, 2026 01:14
@dwisiswant0
dwisiswant0 changed the base branch from main to dev November 9, 2026 01:15
@dwisiswant0 dwisiswant0 changed the title fix(deps): bump github.com/ulikunitz/xz to v0.5.15 fix(deps): bump github.com/yuin/goldmark to v1.7.17 Nov 9, 2026
govulncheck reports GO-2026-5320, cross-site scripting in the goldmark
HTML renderer, as reachable from runner.GetUpdateCallback through the
update check in github.com/projectdiscovery/utils, which renders
release notes with github.com/charmbracelet/glamour. dev pulls in
github.com/yuin/goldmark v1.7.4 that way.

Bump goldmark to v1.7.17, which fixes it. The go directive stays at
1.26.10, and no other requirement changes.

The findings in #219 don't apply to dev. Its dependency graph no
longer includes github.com/ulikunitz/xz, github.com/mholt/archiver, or
github.com/nwaples/rardecode, so govulncheck reports none of
GO-2025-3922, GO-2020-0016, GO-2025-4020, GO-2025-3605, or
GO-2024-2698 there. It still lists advisories in golang.org/x/net
v0.58.0 and golang.org/x/crypto v0.55.0 whose vulnerable code isn't
called.

Fixes: #219
Signed-off-by: Dwi Siswanto <git@dw1.io>
@dwisiswant0
dwisiswant0 force-pushed the dwisiswant0/fix/deps/bump-github-com-ulikunitz-xz-to-v0-5-15 branch from 1b6ba4d to 9883679 Compare November 9, 2026 01:40
@dwisiswant0
dwisiswant0 requested a review from Mzack9999 November 9, 2026 06:24
@Mzack9999
Mzack9999 merged commit 0c43026 into dev Nov 9, 2026
4 checks passed
@Mzack9999
Mzack9999 deleted the dwisiswant0/fix/deps/bump-github-com-ulikunitz-xz-to-v0-5-15 branch November 9, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

govulncheck reports vulnerable github.com/ulikunitz/xz in called code

2 participants